Andrey Anshin

> I think this is good idea, but the ECRDockerCredentialHelper should be part of Amazon provider Yeah it could be. I put it into docker provider for reduce complexity of...

> @potiuk FYI: The same problem exists in Postgres hook: And also AWS RDS IAM auth exists in MySQLHook. However I don't think it even works in MySQL case https://github.com/apache/airflow/blob/5b216e9480e965c7c1919cb241668beca53ab521/airflow/providers/mysql/hooks/mysql.py#L215-L220

> I tihnk this should be changed then also in Postgres and MySQL :) . Let's open Pandora box. What we should do with this ones? _No dependencies in provider...

> Wrong box to open :). This is not part of it. But it do almost the same the same thing that `PostgresHook.get_iam_token` and `MySqlHook.get_iam_token` - grant access by use...

In the ideal world auth to different hooks should be pluggable. In this case user might be auth to Postgres by different ways (Explicit Credentials, pgpass, GSAPI, AWS IAM, etc)...

> Again - your parallells are not entirely correct - it's not "what code is needed". I agree it is similar code. But IMHO it does not matter. What matters...

@mik-laj @potiuk Let's finalise discussion. We not ready to add auth to Amazon ECR by this way it described in the PR for different reasons: 1. We need to move...

@potiuk Right now I thought this is only one approach which could cover: - Auth live in provider packages or user-defined scripts - Do not use `import_string` It is only...

@potiuk I think it would required small changes if compare to the current PR. 1. Rename from `BaseDockerCredentialHelper` to something like `BaseDockerRegistryAuth` credential helper might confuse some user - in...

Will rebase and make changes. Totally forgot about this PR