Tomas Grosup

Results 530 comments of Tomas Grosup

@charlesroddie : You are right, I have rushed the `approved in principle` as I believed comments (the `C` in `RFC`) can still continue and putting the label on does not...

> The main reason for this, on my end is, approving most of the changes in the RFC, without passing the "F# code I love" and "doesn't increase compile time...

Considering the .NetFramework (IDE tooling VS) vs netcoreapp (user code) communication for F#-defined types. Couldn't a TypedTreePickle-derived format be used for the exchange? The inspection would then need to stop...

I do not see why not - I think it first needs a better level of detail (e.g. level of detail similar to the one here https://github.com/fsharp/fslang-design/blob/main/FSharp-6.0/FS-1108-undentation-frenzy.md) to better understand/see...

Not generating the warning in the described case is doable, that was definitely an oversight and mismatch in codegen vs. warning. i.e. changing the warning to allow defining your own...

If you would have hand-written logic for .IsRectangle, you could amend it if/once future extension arrives. Let's say the next ones to be added will be Circle and Square, following...

I think we should allow to polyfill that function yourself, and rework the existing warning to only warn for #cases>1. I am still not convinced that the compiler should automatically...

> To argue that a we should have single-case discriminated unions and at the same time argue that they have no need to discriminate and that all discrimination logic can...

Is there a real-life API which is widely used and requires this pattern? (i.e. an API which really exposes a ReadOnly struct with set property and it is a meaningful...

What is the total build time? It will run on a separate machine, so as long as it does not start the dominate overall CI time, it is fine. Heavy...