Tomas Grosup
Tomas Grosup
@copilot : This is still missing: Length, IsEmpty, Head, Tail, Item, GetSlice Both categories need XML doc comments with time and space complexity details added to the list.fsi (for module...
@copilot : You did not do this at all: List module functions without complexity documentation (35 functions): countBy, findBack, fold, fold2, foldBack, foldBack2, indexed, item, iter2, iteri2, mapFold, mapFoldBack, mapi2,...
@copilot one more time
@copilot : I have merged in main and fixed conflicts. Run trough the full diff and report: A single "+" sign for every comment where your changes are between opening...
@copilot , please add tests to Fsharp.Core.UnitTests projects that will: - Validate that the generated .xml file (Fsharp.Core.XML) loaded next to the assembly, is a valid assembly - Validate separately...
Is the newly added project part of any CI leg (e.g. when VisualFsharp.sln is built?) And test execution?
That makes sense. I will re-review once spec changes are added.
Would a single let binding (= 1 name + 1 value) be considered spreadable as well? It would increase the overlap with other languages, i.e. the expected behavior. At the...
I will have a look. A potential resolution, at least untill FsToolit.ErrorHandling is updated to make use of NRTs, is to offer an alternative option builder which would understand nullable...
If the codefix will come within the same release window, all is good - I am approving.