Tomas Grosup

Results 530 comments of Tomas Grosup

The test has value for sure, as it shows a currently problematic area 👍 .

Any idea where it should go? Since it can resolve to a longer namespace identifier, I don't think placing it right inside of the `(extension from ..)` remark would be...

It looks like the error case is now different for average over an empty collection. If it is the same exception type, and only a different message, we could justify...

1/As per your benchmark, the cost for average might be dominated by doing the casts and additional array allocations. Better try without the mapping step for fully prove that. 2/The...

> Average will now throw different exception, so it's a breaking change at this point. @Thorium: This does not mean it is a showstopper. If the change is good from...

Framework-dependent runtime switch would solve this (and since it is static, I would hope JIT would eliminate such branching), but is not something we are doing in FSharp.Core. On Desktop:...

I meant a statically stored flag based on something like: ```fsharp open System.Runtime.InteropServices let runtimeDescription = RuntimeInformation.FrameworkDescription let hasLinqAcceleration = runtimeDescription > "..." // string-based logic here ``` And switching...

> After `Sum` is solved, I guess it's time for `SumBy` to do the same, because SumBy is the more commonly used in F#. There is System.Linq.Enumerable.Sum overload that takes...

> > However they will be defined on both net48 and net9.0 > > .NET Framework is not .NET Standard 2.1 compatible, thus .NET Standard 2.1 version shouldn't need runtime...

Tests were failing, otherwise it was good. The results have expired since, let me get fresh results.