Tomas Grosup comments

Results 522 comments of


                                            Tomas Grosup

Obsolete warning isn't produced for some obsolete symbol usages

> @auduchinok I believe I have covered all the cases in this issue including events 😀See https://github.com/dotnet/fsharp/blob/main/tests/FSharp.Compiler.ComponentTests/Language/ObsoleteAttributeCheckingTests.fs Good job Edgar! Can this issue now be closed ?

Module and partially qualified namespace type shadowing interaction

(probably a broader issue about type direction, also related to tuples, collections,...)

Implement tooltips for keywords

Proposal: Renders the keyword itself (if the configured coloring for keywords), and below it the longer description as text. I am checking the keyword descriptions, but so far they seem...

Implement tooltips for keywords

The icon was not appropriate, you are right and I am not a person with a good visual judgement. This one makes it look more like a keyword:

Nested reference type record values and nullable constraints

Please convert to suggestion if not covered already.

ValueOption equality on expression trees causes crash

https://github.com/dotnet/fsharp/pull/11681 is merged, this can be closed (by design, solution exists)

Microsoft.FSharp.Math functions should support units of measure

Min/Max/Abs functions do support units of measure ;; those are also the functions where it makes sense to keep the units. I will close the issue for now - please...

Different de-serialization behavior for immutable struct and class when DataMember attributes are present

Hi @JamesNK . Would you accept a PR if I attempted to fix this issue, since we are now (net7) seeing it for F# records using `[]` attribute? I have...

Enable roundtrip for F# struct record with datamember attribute

Hi all, is there anything else I should improve here, or is this ready to be merged now?

Enable roundtrip for F# struct record with datamember attribute

@JamesNK : Hi James, would now be a better time to merge this in please?