Tomas Grosup

Results 530 comments of Tomas Grosup

@copilot : Your changes triggered two following build time errors: D:\a\_work\1\s\src\Compiler\TypedTree\TypedTreeOps.fs(3176,6): error FS0311: The type definitions for type 'DisplayEnv' in the signature and implementation are not compatible because the field...

@copilot : The code does not even build. Try building it first, fix the build errors, and then continue to fixing tests. Work using the `FSharp.Compiler.Service.sln` for build and test.

The code does not even build. Try building it first, fix the build errors, and then continue to fixing tests. Work using the FSharp.Compiler.Service.sln for build and test.

@copilot The code does not even build. Try building it first, fix the build errors, and then continue to fixing tests. Work using the FSharp.Compiler.Service.sln for build and test.

@copilot ## ❌ Build / Test Failures ### 💥 Issues - Bash exited with code '1'. — Plain_Build_Linux/Regular rebuild of FSharp.Compiler.Service.sln Plain_Build_MacOS/Regular rebuild of FSharp.Compiler.Service.sln - Cmd.exe exited with code...

@copilot : You caused 3 test failures. First is the name of the failing test, second is the test failure details: FSharp.Compiler.Service.Tests.ProjectAnalysisTests.Test project3 all uses of all signature symbols :...

@copilot : No, that was wrong. Now your implementation does not do anything useful at all - plase fix the original issue now. Instead of removing the implementation, which was...

Run the test and address its failure. Also, create release notes entry for this change.

@copilot : The following three tests are failing. You might have to redo the tests and their expectations. The change is OK, just adjust tests. I repeat, do not revert...