Scott Kay

Results 82 comments of Scott Kay

Closed / Reopened To Re-Trigger Build Actions

> Am I missing something, or is there no test that a disabled module is excluded from the built plans? I see tests to ensure disabled modules make it on...

You also need to register the intertech name and adapter in a few other places. Please see[ this section](https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#register-with-the-core) in the docs or look at [this other PR](https://github.com/prebid/prebid-server/pull/3727) for an...

> I had to put an RPS limit on the load balancer. IMHO its good practice to use backpressure limiting layers in front of Prebid Server. This is the approach...

@linux019 - You commented on this PR. Do you wish to re-review?

Looks good to me. Your proposal looks perfectly in-line for Go programs. I look forward to consolidating all glog references to a single location, as it will allow us to...

Discussed with the PBs-Go team. You're good to proceed with development. We'll review more specifics in the eventual PR.

Why is a "test mode" necessary? Testing should be performed on a non-prod or local instance.

This needs to be an issue for the Committee to discuss. All current upgrade paths prefer the new location if present and ignore the old location, which may also be...

> In our case we are choosing the old location but prebid server bid adapter has chosen the new location. That's ok. Prebid Server will provide the correct location to...