Rise: Add test mode param
- Add the test mode
- Add some test and fix them
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, bf31125b61b1b036677c96decb24c0c481aa418e
rise
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:33: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:41: MakeRequests 78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:72: MakeBids 88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:109: extractBidderParams 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:138: getMediaTypeForBid 100.0%
total: (statements) 90.9%
@pm-shriprasad-marathe can you please review?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, e5fabebc5249bb1a81183959a2199fafabe5105d
rise
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:33: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:41: MakeRequests 78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:72: MakeBids 88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:109: extractBidderParams 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:138: getMediaTypeForBid 100.0%
total: (statements) 90.9%
Why is a "test mode" necessary? Testing should be performed on a non-prod or local instance.
@SyntaxNode Good point—ideally tests would run on a non-prod or local PBS instance. But currently, we don’t have an easy way to spin one up, which limits our ability to test end-to-end flows. The testMode flag lets us safely route traffic to a controlled test endpoint without affecting prod behavior. It’s a temporary workaround until we improve PBS test coverage.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 89bd417be7dcefd521bf48cec60d83b43c946861
rise
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:32: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:40: MakeRequests 78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:71: MakeBids 88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:108: extractBidderParams 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:136: getMediaTypeForBid 100.0%
total: (statements) 90.7%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 518829cf64baf8ad54a3f55bd06fc1c94a2b7006
rise
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:32: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:40: MakeRequests 78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:71: MakeBids 88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:108: extractBidderParams 100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:136: getMediaTypeForBid 100.0%
total: (statements) 90.7%
Please close this pr, we opened a new one: https://github.com/prebid/prebid-server/pull/4457