prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Rise: Add test mode param

Open SamuelRise opened this issue 8 months ago • 1 comments

  • Add the test mode
  • Add some test and fix them

SamuelRise avatar Apr 20 '25 09:04 SamuelRise

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bf31125b61b1b036677c96decb24c0c481aa418e

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:33:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:41:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:72:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:109:	extractBidderParams	100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:138:	getMediaTypeForBid	100.0%
total:								(statements)		90.9%

github-actions[bot] avatar Apr 20 '25 09:04 github-actions[bot]

@pm-shriprasad-marathe can you please review?

bsardo avatar Apr 28 '25 21:04 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e5fabebc5249bb1a81183959a2199fafabe5105d

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:33:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:41:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:72:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:109:	extractBidderParams	100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:138:	getMediaTypeForBid	100.0%
total:								(statements)		90.9%

github-actions[bot] avatar May 29 '25 13:05 github-actions[bot]

Why is a "test mode" necessary? Testing should be performed on a non-prod or local instance.

SyntaxNode avatar May 29 '25 15:05 SyntaxNode

@SyntaxNode Good point—ideally tests would run on a non-prod or local PBS instance. But currently, we don’t have an easy way to spin one up, which limits our ability to test end-to-end flows. The testMode flag lets us safely route traffic to a controlled test endpoint without affecting prod behavior. It’s a temporary workaround until we improve PBS test coverage.

innay avatar Jun 04 '25 11:06 innay

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 89bd417be7dcefd521bf48cec60d83b43c946861

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:32:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:40:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:71:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:108:	extractBidderParams	100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:136:	getMediaTypeForBid	100.0%
total:								(statements)		90.7%

github-actions[bot] avatar Jul 08 '25 13:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 518829cf64baf8ad54a3f55bd06fc1c94a2b7006

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:32:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:40:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:71:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:108:	extractBidderParams	100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:136:	getMediaTypeForBid	100.0%
total:								(statements)		90.7%

github-actions[bot] avatar Jul 08 '25 13:07 github-actions[bot]

Please close this pr, we opened a new one: https://github.com/prebid/prebid-server/pull/4457

innay avatar Jul 29 '25 08:07 innay