Scott Kay

Results 82 comments of Scott Kay

> the `validate` test failure seems spurious - could you please restart the job? It happens in `analytics/agma/agma_module_test.go` which is not modified in the change, and that package is not...

@dmitris Friendly reminder. Haven't heard from you recently.

Thank you for kicking this off @bretg. > I propose keeping the removed fields so PBS validation is done on a superset of 2.5 and 2.6. I am interested in...

> perhaps adapters could somehow say where they want it? Agree. FWIW: I conveyed to the IAB the problem the ecosystem would encounter if the group decided to promote the...

FYI: $.imp[].rewarded was actually written in the spec as "reward" and will be changing to "rwdd".

> rwdd? ugh. updated the description Really. Designed by committee. :-/

> * $.seatbid[].bid[].tactic: pass through to response The tactic id is not new in OpenRTB 2.6. It was introduced in 2.5.

@benjaminch This looks very interesting. Thank you for taking the initiative. I discovered this recently as well thanks to Grayson Hardaway's GoLang NYC talk. We're currently in the middle of...

> (1) bidderParamsInReqExt seems always nil, since the ext part of the requestExt is previously constructed without the bidderparams part in function createBidExtension(/endpoints/openrtb2/video_auction.go). The video endpoint does not support `request.ext.prebid.bidderparams`,...

It's not expected. Looks like this was recently introduced in tests for the Floors feature. Is this the only data race found?