Syméon

Results 54 comments of Syméon

I think you are focusing on the wrong part. You need to find the place in your code that calls this code. What are you doing to trigger the exception?...

It seems additionally that the plugin org.unbroken-dome.test-sets version 4.0.0 is not compatible with the 8+ version (for the same reason). Upgrade to version 4.1.0 (the latest fixes it). We should...

The changes seem fine, but I have to say that I don't understand what situation you are tackling with this one. The index is needed only when we create them...

Ok. My only comment (but maybe that will come with your changes in RichTextFX) is that maybe we should test via a UT that it does refresh the paragraph with...

Thanks for taking the time to do that. I listed them previously: * fromItem == toItem * fromItem > toItem * min > start * max < end * min...

Quick overall question: there is no test for the added code?

Approved overall. For the ReactFX thing, I understand you want to copy for the time being. But looking at the bigger picture, I think it's rather risky to start on...

Just a quick note to make it visible: I had some response on ReactFX, so, maybe we can manage to get a new build out (nothing certain for now).

A small comment to let you know that some discussions are happening on RichTextFX PR about the content of the change. The list was also slightly modified (and there might...

Here is some of the code if that helps understanding: The table ```java public class CustomTable extends AnchorPane { public CustomTable(List columns) { ObservableList observableList = FXCollections.observableList(columns); // Following is...