Syméon

Results 54 comments of Syméon

I don’t see breaking the API as inherently problematic—provided there’s a clear and justified purpose behind it. Typically, breaking changes are signaled by incrementing the **major version**, following the [Semantic...

I was going through the code, and I wanted to document some of things we could consider for cleanup. One thing I saw that could definitely need some cleanup are...

> But generally my main desire of such a refactoring effort would be higher test coverage and more thorough tests (Though, I understand testing a UI focused library is typically...

I have done PR #1303 to showcase what could be a methodology: 1. I extracted some part of the logic into a unit that can be tested (with minimal/no modification)...

From what I have seen when I undo, the `UndoManager` has the position, the removed and the added text. But it does not contain the previous caret position (in `PlainTextChange`)....

After some research, it seems like the caret position is moved after the redo in `RedoUtils` method `applyMultiRichTextChange` by calling `moveToChange`. In the example I gave the change is `(start:...

I will add some Unit tests for all cases, for me there are 4: 1. Add some text 2. Delete some text with "delete" key 3. Delete some text with...

I'm actually wrong when stating we can divide the problem. I could easily fix the replace issue but the delete needs the information about the previous position of the caret....

Thanks for that tip, I'll have a look. In the meantime I have extended the UT to include more cases. There is one more wrong thing I have seen. If...

@Jugen I looked at that code which seems to define how the caret is repositioned after the change. But that is not relevant in that case, as the caret positioning...