Flowless icon indicating copy to clipboard operation
Flowless copied to clipboard

Add item index to Cell creation

Open Jugen opened this issue 5 months ago • 5 comments

This PR adds a new VirtualFlow construction method that takes a BiFunction parameter so that the item index is available for the Cell factory.

Issue FXMisc/RichTextFX#1273 refers.

Jugen avatar Aug 05 '25 10:08 Jugen

Quick overall question: there is no test for the added code?

Symeon94 avatar Aug 05 '25 11:08 Symeon94

I've updated to include UT.

Jugen avatar Aug 05 '25 13:08 Jugen

Approved overall. For the ReactFX thing, I understand you want to copy for the time being.

But looking at the bigger picture, I think it's rather risky to start on the idea that ReactFX is a dead project. It would be better if we could get back control over the library to be able to maintain it.

Symeon94 avatar Aug 05 '25 14:08 Symeon94

Just a quick note to make it visible: I had some response on ReactFX, so, maybe we can manage to get a new build out (nothing certain for now).

Symeon94 avatar Aug 06 '25 05:08 Symeon94

A small comment to let you know that some discussions are happening on RichTextFX PR about the content of the change. The list was also slightly modified (and there might be additional fixes depending on the outcome of the discussion).

Symeon94 avatar Aug 11 '25 06:08 Symeon94