Suvrat Acharya comments

Results 55 comments of


                                            Suvrat Acharya

Harmonize `testAdapter` and `addAdapter` Methods in `ConnectUtils`

@tenthe What do you mean by 'harmonize'? Can I just make a new method say `setupAdapterConfiguration` and move all the common logic in this method and implement this method in...

Harmonize `testAdapter` and `addAdapter` Methods in `ConnectUtils`

@tenthe >It would be good to have one or more expressive methods where it is clear what is happening and how they can be used. Yes, I did notice that...

Harmonize `testAdapter` and `addAdapter` Methods in `ConnectUtils`

@tenthe I noticed that there are a lot of pending 'good-first-issue' from 2023 is it ok if open prs for them without asking for assignment?

[Java] Add InsertRetryPolicy for non-successful BigQuery insertAll responses

assign set of reviewers

[Java] Add InsertRetryPolicy for non-successful BigQuery insertAll responses

Hey @shunping @m-trieu Gentle ping, please take a look at this pr and provide me with comments to improve this pr. Thank you.

[Java] Add InsertRetryPolicy for non-successful BigQuery insertAll responses

@shunping There are 2 failing tests but they dont seem to concern the files I have worked on. Could you please take a look. Thank you.

Expunge stale loggers in InternalLoggerRegistry on method invocation

@vy I have always had a hard time with test cases, I have opened a pr regardless please take look and provide further insights on how i can improve it.

Expunge stale loggers in InternalLoggerRegistry on method invocation

Ok sorry about that, I have put back all the comment blocks as they were.

[Java] Add parsedData to Hl7v2Message and Update HL7v2IO Docs

assign set of reviewers

[Java] Add parsedData to Hl7v2Message and Update HL7v2IO Docs

@robertwb @Abacn @svetakvsundhar Hey gentle ping. Could you please take a look and provide me with comments to improve this pr. Thank you.