beam icon indicating copy to clipboard operation
beam copied to clipboard

[Java] Add parsedData to Hl7v2Message and Update HL7v2IO Docs

Open Suvrat1629 opened this issue 9 months ago • 23 comments

Please add a meaningful description for your change here


This PR addresses #20452 by adding support for the parsedData field in the Hl7v2Message class, enabling users of the HL7v2IO connector who do not rely on schematized parsing to utilize HL7v2 messages from the Google Cloud Healthcare API.

Fixes #20452

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Suvrat1629 avatar Mar 07 '25 16:03 Suvrat1629

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Mar 07 '25 18:03 github-actions[bot]

assign set of reviewers

Suvrat1629 avatar Mar 08 '25 07:03 Suvrat1629

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @Abacn for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Mar 08 '25 07:03 github-actions[bot]

@robertwb @Abacn @svetakvsundhar Hey gentle ping. Could you please take a look and provide me with comments to improve this pr. Thank you.

Suvrat1629 avatar Mar 12 '25 13:03 Suvrat1629

Hi @svetakvsundhar would you mind taking a look of this HealthCareIO PR, thanks!

Abacn avatar Mar 12 '25 14:03 Abacn

@svetakvsundhar I did fix the spotless checks and was working on the tests, I tried running the test file as it was and got the following error:org.apache.beam.sdk.util.UserCodeException: java.io.IOException: Your default credentials were not found. To set up Application Default Credentials for your environment. Is it necessary for me to make an account on google cloud or is there a way to test without creating a account?

Suvrat1629 avatar Mar 15 '25 06:03 Suvrat1629

Reminder, please take a look at this pr: @robertwb @Abacn @svetakvsundhar

github-actions[bot] avatar Mar 22 '25 12:03 github-actions[bot]

@svetakvsundhar I did fix the spotless checks and was working on the tests, I tried running the test file as it was and got the following error:org.apache.beam.sdk.util.UserCodeException: java.io.IOException: Your default credentials were not found. To set up Application Default Credentials for your environment. Is it necessary for me to make an account on google cloud or is there a way to test without creating a account?

@svetakvsundhar gentle reminder. Could you help me.

Suvrat1629 avatar Mar 24 '25 18:03 Suvrat1629

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Mar 27 '25 12:03 github-actions[bot]

Reminder, please take a look at this pr: @damondouglas @damondouglas @svetakvsundhar

github-actions[bot] avatar Apr 04 '25 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 08 '25 12:04 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @damondouglas @svetakvsundhar

github-actions[bot] avatar Apr 16 '25 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 21 '25 12:04 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles @damondouglas @svetakvsundhar

github-actions[bot] avatar Apr 28 '25 12:04 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles @damondouglas @svetakvsundhar

github-actions[bot] avatar May 06 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 09 '25 12:05 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @damondouglas @svetakvsundhar

github-actions[bot] avatar May 16 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 21 '25 12:05 github-actions[bot]

@svetakvsundhar please take a look at this comment again. Thank you

Suvrat1629 avatar May 21 '25 14:05 Suvrat1629

Reminder, please take a look at this pr: @Abacn @damondouglas @svetakvsundhar

github-actions[bot] avatar May 29 '25 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 02 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @chamikaramj @damondouglas @svetakvsundhar

github-actions[bot] avatar Jun 10 '25 12:06 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 13 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @damondouglas @svetakvsundhar

github-actions[bot] avatar Jun 20 '25 12:06 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jun 24 '25 12:06 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles @damondouglas @svetakvsundhar

github-actions[bot] avatar Jul 02 '25 12:07 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jul 07 '25 12:07 github-actions[bot]

Reminder, please take a look at this pr: @ahmedabu98 @damondouglas @svetakvsundhar

github-actions[bot] avatar Jul 14 '25 12:07 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @damondouglas for label io. R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Jul 16 '25 12:07 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @damondouglas @svetakvsundhar

github-actions[bot] avatar Jul 24 '25 12:07 github-actions[bot]