Susko3
Susko3
> When I press A or any other key it is counted as 2 times. (only happens with letters) That's to be expected, as both `InputKey.A` and `InputKey.KeycodeA` are pressed...
I was working on something else when I noticed `ManualInputManager.Keys(PlatformAction)` needs consideration in this pull, as it's currently just pressing invalid `Key`s when `InputKey.Scancode*` is used. Haven't yet tested. https://github.com/ppy/osu-framework/blob/75ed421f60228920abd819cebc5982cb7799bbbb/osu.Framework/Testing/Input/ManualInputManager.cs#L107-L120
> I am wondering whether we can change direction here and sacrifice backwards compatibility for a simpler diff. I'd begin by not bothering to add all of that `Keycode{A-Z}` stuff...
> SDL Android looks for the SDL main function from dynamic library symbol. Let me know if there's any better way. I'd be happy to make it better. You could...
https://github.com/libsdl-org/SDL/commit/3a482ebae062cbc127e4e0faf9a07f69b54b7419 could be used to avoid the need for `SDL2AndroidMainSetter`. It's currently only available in SDL3, but we could backport it to SDL2.
The main problem with the keyboard is that we're calling `SDL_StartTextInput` before [`SDL_SetTextInputRect`](https://wiki.libsdl.org/SDL3/SDL_SetTextInputRect). This leads to the keyboard using the stale text input rect value. From `SDL_SetTextInputRect` documentation: > To...
I've reported https://github.com/ppy/osu-framework/pull/6105#pullrequestreview-2011866789 upstream in https://github.com/libsdl-org/SDL/issues/9591. This issue is not unique to android and can fail on Windows too.
Yep this is good to go, just needs merge master + removal of no longer necessary workarounds: 1. Revert `SDL3Window_Windowing.cs` 2. `AndroidGameWindow.Create()` workarounds Also [the `AndroidGameHost` shouldn't be disposed](https://github.com/ppy/osu-framework/pull/6105#discussion_r1573351603).
> What about [this thing](https://github.com/ppy/osu-framework/pull/6105/files#diff-29dfec3d1a572a8fa40cc6228f95219bda6ccc551190bee986d3e194d0ecd03aR530-R531)? I don't see it being moved anywhere? You're correct, that has to stay, I must have confused it with the dropped events that were fixed...
> just need to remove the `osuTK.Android` reference as it's no longer needed. Or you can merge right now, and we do this later in osuTK cleanup.