Ben Kochie

Results 1558 comments of Ben Kochie

No, that is message is from an older version of the smokeping_prober. The message was removed when we added dynamic reload support. Reported latency may be going up because the...

> Is this some issue with Prometheus's addToBucket concurrency? Maybe we need more distinct metrics instead of label pairs? No, the timing is calculated entirely outside of the metric manipulation....

FYI, this PR should improve performance: https://github.com/SuperQ/smokeping_prober/pull/178

This needs a DCO sign-off. You can use `git commit -s --amend` to add it.

I noticed upstream Prometheus updated this library, mirror changes from https://github.com/prometheus/prometheus/pull/16168.

No worries, I figure this is better after reading over the Prometheus use of the library. More consistent.

A couple of linter errors to fix.

:eyeglasses: @dormando

Fine with me. Happy to rebase and lint later.