common icon indicating copy to clipboard operation
common copied to clipboard

config: allow exposing real secret value through marshal

Open GiedriusS opened this issue 2 years ago • 1 comments

There are external projects out there that marshal/unmarshal the Prometheus config that has secrets. To get the real value currently such horrible workarounds are in place: https://github.com/tkestack/kvass/blob/master/pkg/sidecar/injector.go#L175-L214

Let's add a way to get the original values through the Secret type to avoid such things.

GiedriusS avatar May 15 '23 08:05 GiedriusS

Good idea, minor nit about the test setup.

SuperQ avatar Feb 28 '24 13:02 SuperQ

Is there any plan to merge the code in the next period of time?

alita1991 avatar Apr 09 '24 16:04 alita1991

thanks, I think we can do the test improvement later on.

roidelapluie avatar Apr 15 '24 08:04 roidelapluie