Ben Kochie

Results 1558 comments of Ben Kochie

I think we need you to rebase and squash your commit history here. There are now 57 commits in the PR history which is quite a mess.

Yes, this needs the commit history cleaned up.

There are several examples of them in `/cmd/postgres_exporter/...`. They activate in CI via `go:build integration` tags in the test files.

A `pg_stat_wal` collector sounds like a great idea.

Looks like a couple tests need fixing.

I'm not sure we should do this. This copies in the Debian signature, which misrepresents what out BusyBox image is.

Yes, adding a custom distroless os-release makes more sense to me. Interestingly I checked the official busybox container, it also does not have an os-release.

Build is failing. :thinking:

I might hold off on this, as we have found some issues with the new route prefix changes.