ansible icon indicating copy to clipboard operation
ansible copied to clipboard
verified publisher icon prometheus-community

feat: add elasticsearch_exporter

Open juju4 opened this issue 11 months ago • 9 comments

This mostly mirrors node_exporter Tested on Ubuntu 24.04

juju4 avatar Jan 19 '25 00:01 juju4

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

github-actions[bot] avatar Jan 19 '25 00:01 github-actions[bot]

There are 2 extra commits that are in for some reason and that I signoff with the rest. should it be amended? recommended way to fix?

juju4 avatar Jan 19 '25 20:01 juju4

and ci molecule and ansible-test-integration still don't run. something else missing?

juju4 avatar Jan 19 '25 20:01 juju4

additional feedback? requested change has been done but few tests are still skipped.

juju4 avatar Feb 09 '25 20:02 juju4

It seems multiple fails are due to missing ansible variable resulting in undefined error. Is gather facts disabled? supposed to be? ansible_selinux - https://github.com/prometheus-community/ansible/actions/runs/13358246410/job/37304026730#step:3:2875 ansible_architecture - https://github.com/prometheus-community/ansible/actions/runs/13358246410/job/37304029131#step:3:2864

juju4 avatar Feb 16 '25 20:02 juju4

hopefully sign-off amend did not create too much mess...

juju4 avatar Feb 23 '25 20:02 juju4

Please update what are next steps to get this merged. thanks

juju4 avatar Apr 06 '25 23:04 juju4

I think we need you to rebase and squash your commit history here. There are now 57 commits in the PR history which is quite a mess.

SuperQ avatar Apr 07 '25 12:04 SuperQ

rebase and squash done but still messy because of sign-off amend.

juju4 avatar Apr 19 '25 22:04 juju4

Should we close this one and submitted as new PR to have clean sign-off/DCO? Please confirm good to merge as is or new PR or remaining issues.

juju4 avatar Jun 14 '25 21:06 juju4

Yes, this needs the commit history cleaned up.

SuperQ avatar Jun 15 '25 15:06 SuperQ

Closing as replaced by https://github.com/prometheus-community/ansible/pull/607

juju4 avatar Jun 21 '25 21:06 juju4