Ben Kochie
Ben Kochie
This is a low priority task, as there is no vulnerability. Your security scanner is faulty. Please do not report raw vulnerability scanner results. They are prone to false positives...
In this specific case, the node_exporter does not openssl or libssl, as the software is written in Go and uses Go's TLS implemenation.
I did some simple benchmarks of this, it only adds about 50ns to the command execute. We also do a similar `.lower()` on HTTP calls in `/baseplate/clients/requests.py`.
Ping, can this be merged?
Yes, I would like to see this merged so we can iterate on additional featres.
Ping @gotjosh @simonpasquier
This needs a rebase. Also, would you mind squashing all the fixes into one commit?
Looking over the other functionality, we do send resolved messages to PagerDuty. It seems like "Cancel" is the equivalent for Pushover. We should support this. Users can control the behavior...
This needs a DCO sign-off. You can use `git commit -s --amend` to add it.
Should be possible with the [upstream pro-bing](https://pkg.go.dev/github.com/prometheus-community/pro-bing#Pinger.SetDoNotFragment). library. PRs welcome.