baseplate.py
baseplate.py copied to clipboard
Lowercase redis command labels
๐ธ TL;DR
In order to make baseplate.py redis client Prometheus labels consistent with other systems / clients, lowercase the redis_command label values.
๐ Details
Design Doc
Jira
๐งช Testing Steps / Validation
โ Checks
- [x] CI tests (if present) are passing
- [x] Adheres to code style for repo
- [ ] Contributor License Agreement (CLA) completed if not a Reddit employee
I did some simple benchmarks of this, it only adds about 50ns to the command execute. We also do a similar .lower() on HTTP calls in /baseplate/clients/requests.py.
Spec update has been approved and merged.
Ping, can this be merged?