baseplate.py icon indicating copy to clipboard operation
baseplate.py copied to clipboard

Lowercase redis command labels

Open SuperQ opened this issue 3 years ago โ€ข 3 comments

๐Ÿ’ธ TL;DR

In order to make baseplate.py redis client Prometheus labels consistent with other systems / clients, lowercase the redis_command label values.

๐Ÿ“œ Details

Design Doc

Jira

๐Ÿงช Testing Steps / Validation

โœ… Checks

  • [x] CI tests (if present) are passing
  • [x] Adheres to code style for repo
  • [ ] Contributor License Agreement (CLA) completed if not a Reddit employee

SuperQ avatar Nov 30 '22 14:11 SuperQ

I did some simple benchmarks of this, it only adds about 50ns to the command execute. We also do a similar .lower() on HTTP calls in /baseplate/clients/requests.py.

SuperQ avatar Nov 30 '22 14:11 SuperQ

Spec update has been approved and merged.

bjk-reddit avatar Dec 05 '22 21:12 bjk-reddit

Ping, can this be merged?

SuperQ avatar Mar 06 '23 13:03 SuperQ