alertmanager
alertmanager copied to clipboard
Add godot linter
Adds the godot linter to make sure all comments are captialized and end in a full stop (period).
Good to know it works 😄
/go/bin/golangci-lint run ./...
matchers/parse/lexer.go:254:4: Sentence should start with a capital letter (godot)
// it returns nil if the next rune is valid, otherwise an expectedError
^
matchers/parse/parse.go:199:44: Comment should end in a period (godot)
// open brace has a matching close brace
^
matchers/parse/parse.go:223:44: Comment should end in a period (godot)
// open brace has a matching close brace
^
nflog/nflogpb/set_test.go:29:27: Sentence should start with a capital letter (godot)
{newSubset(), true}, // empty subset
^
nflog/nflogpb/set_test.go:57:27: Sentence should start with a capital letter (godot)
{newSubset(), true}, // empty subset
^
pkg/labels/parse.go:140:27: Comment should end in a period (godot)
// Unescape the rawValue:
^
make: *** [Makefile.common:173: common-lint] Error 1
This needs a rebase. Also, would you mind squashing all the fixes into one commit?
@grobinson-grafana ping
@TheMeier I don't have merge permissions so I can't merge this 😞 Needs to be @gotjosh or @simonpasquier