Jonathan Coates

Results 565 comments of Jonathan Coates

Finally got round to looking at this, sorry. It looks much nicer. 👍 Just a couple of questions/comments: > New methods: `term.getFontName()` and `term.setFontName()` > Each Computer and Monitor contains...

You could arguably have something like `io.utf8` or `utf8.io`, which acts like the default `io` library but on utf8 strings: this provides `.write` and `.read` functionality. I dunno, if feels...

> If we change it we will get a "2" and a "??" because the LuaString will hold two bytes (for utf8). It shouldn't. The original string library _must_ still...

Judging by the changelog and images that's looking good! I'll have a play with it later tonight. Just a couple of nitpicky things and some questions: - I'd chuck `Utf8API`...

> > Is loadutf8 needed: > > If we like to be fully backward compatible we need it. Because the dan hacks corrupt the utf characters. Either we break compatibility...

Just trying this out today and noticed a issue with the scroll offset not changing when tabs are closed: ![2017-11-14_23-36-42](https://user-images.githubusercontent.com/4346137/32810857-cb6ac4fe-c994-11e7-8181-de651040794d.gif) - Open lots of tabs in multishell (I ran `bg`...

Thought I'd commented this a couple of weeks ago but apparently I didn't. Sorry. @Wilma456 The fix works, but I feel it would be nicer closing a tab scrolled the...

Just a couple of suggestions: - Instead of storing a list of all computers and looping through them, just use `ComputerCraft.serverComputerRegistry.lookup`. This means you won't get memory leaks with the...

> Make the ID optional letting the computer decide to handle it as otherwise you are telling users on your server to add an arbitrary number before commands which is...

@KingofGamesYami This'll need rebasing onto master: it's been updated to 1.11.2 which introduces some incompatibilities.