ComputerCraft icon indicating copy to clipboard operation
ComputerCraft copied to clipboard
verified publisher icon dan200

Make Multishell Scrollable

Open JakobDev opened this issue 8 years ago • 5 comments

You can now Scroll through the Programlist, if the list bigger than your Screen.

multi

JakobDev avatar Aug 08 '17 17:08 JakobDev

@dan200 Changes are now done

JakobDev avatar Sep 10 '17 15:09 JakobDev

I added a patch from @BombBloke which allow the scroll with the mousewhell.

JakobDev avatar Sep 11 '17 13:09 JakobDev

Just trying this out today and noticed a issue with the scroll offset not changing when tabs are closed:

2017-11-14_23-36-42

  • Open lots of tabs in multishell (I ran bg about 10 times).
  • Scroll to the far right but keep the focus in the first tab.
  • Start closing tabs.

I think the best thing to do would be to ensure the offset is valid before each menu redraw, clamping it if required.

SquidDev avatar Nov 14 '17 23:11 SquidDev

@SquidDev Thanks for reporting. The Bug is now fixed.

JakobDev avatar Nov 15 '17 20:11 JakobDev

Thought I'd commented this a couple of weeks ago but apparently I didn't. Sorry.

@Wilma456 The fix works, but I feel it would be nicer closing a tab scrolled the selection to the left again, so that the whole tab list is always full - rather than just having one tab on the far left.

SquidDev avatar Dec 01 '17 19:12 SquidDev