sonar-dotnet

sonar-dotnet copied to clipboard

### Description When using null conditional like in the below example, S2259 gives a FP. It may be the fact that `string.Equals` does not apply the correct constraints on the...

andrei-epure-sonarsource

Fix S2259 FP: Lifted operator results in null value in value type comparison

8

### Repro steps ```cs public class TokenService { private AccessTokenModel _lastTokenModel; public DateTime? LastIssue { get; private set; } public string GetAccessToken() { if (LastIssue + _lastTokenModel?.ExpiresIn > DateTime.Now) return...

aureole82

S2259 FP: Null conditional combined with null coalescing

2

### Description S2259 is incorrectly reported when using null conditional with null coalescing operator. ### Repro steps ```cs private void Sample() { string someString = null; if (!someString?.Contains("a") ?? true)...

przemyslaw-piescik

S2259 FP: return value of ToList() is not null

2

### Description S2259 raises an issue telling that the return value of the ToList() is is null on at least one execution path. ### Repro steps ``` public static long...

csaba-sagi-sonarsource

S2259 FP: Combining a null-coalescing operator with the “continue” keyword

1

### Description Combining a null-coalescing operator with the “continue” keyword in a for loop still reports the variable usage with is null on at least one execution path. ### Repro...

dmitry-golovinov-sonarsource

S2259 nondeterministic result

1

An issue on peach: https://peach.sonarsource.com/issues?open=AXoJkYeoXaALAbC4wYt6&rules=csharpsquid%3AS2259&statuses=CLOSED Has history like this: ``` November 21, 2021, 1:12 AM Resolution removed (was FIXED)Status changed to OPEN (was CLOSED) November 21, 2021, 1:49 AM Resolution...

pavel-mikula-sonarsource

Fix S2259 FP: Unrelated ref parameter call breaks constraints

1

### Description The following example produces a false positive of rule S2259 on the `Length` property access, claiming that the array `a` could be `null`in some cases. ### Repro steps...

moellerm

Fill basic constraints for SE of Switch Expressions

1

Symbolic Execution: SwitchArms of C# 8 switch statements does not build constraints for their symbolic value. Basic constraints for simple cases (true / false literals, non-null constraints) should be added....

pavel-mikula-sonarsource

For purpose of development, the Sonar SE engine is used as default. We need to switch it to Roslyn. Or maybe consider using both engines together in case we don't...

pavel-mikula-sonarsource

Implement S2259 for VB.NET. This rule will be available only for MsBuild 16+ and VS2019+

pavel-mikula-sonarsource