sonar-dotnet

sonar-dotnet copied to clipboard

Bring "GetIdentifier" for VB and CSharp up to par.

2

The implementations and signatures of "GetIdentfier" between VB and CSharp were not equivalent. VB returns "SyntaxToken", while CS returned "SimpleNameSyntax". The VB version is better because an identifier can be...

martin-strecker-sonarsource

Tests: Issue(s) expected but not raised should have a stacktrace with a link to the test file

2

If an issue is expected (Noncompliant) but not raised, the test fails, but the stack trace with the link to the location is missing. **Note** `IssueLocationCollector.GetExpectedIssueLocations` throws `InvalidOperationException`s which should...

martin-strecker-sonarsource

NET-1950 Fix S1128 FP: documentation tags with dotnet build command

10

### History Issue with documentation tags was originally reported and fixed in #2694 with a simple reproducer: ```C# using System; // Compliant, used by cref. namespace SonarAnalyzer.Experiments.CSharp { public enum...

pavel-mikula-sonarsource

S3343: Add tests for [CallerArgumentExpression] and support local functions

2

Fixes #5925

martin-strecker-sonarsource

S2259: "Null pointer dereference" should not raise if the variable was tested with custom assertion method before

5

### Description S2259 is raised even if tested before with custom assertion method. This issue therefore is similar to https://github.com/SonarSource/sonar-dotnet/issues/349 with the difference that I am referring to a custom...

llfab

Fix S2259 FN: Linq 'XxxOrDefault' extensions should create null and not-null constraints

4

### Description As reported on [this community thread](https://community.sonarsource.com/t/c-missing-simple-possible-null-references/22784) Linq `FirstOrDefault()` extension methods does not trigger S2259 "'item' is null on at least one execution path." All OrDefault Linq extensions should...

pavel-mikula-sonarsource

Fix S2259 FP: "Null pointer dereference" should not raise if the variable was tested with Debug.Assert before

9

[RSPEC-2259](https://jira.sonarsource.com/browse/RSPEC-2259) - [ ] Reintroduce learning from Debug.Assert - [ ] Revert #397 - [ ] Introduce means to not raise "Expression always true/false" on values that were checked with...

valhristov

Rule S2259 FP: symbolic execution does not enter the `for` loop

3

### Description The following code snippet seems to trigger a false positive S2259 `'lastEx' is null on at least one execution path.` on the last line with the throw statement:...

bzuu

FPs and FNs in the Symbolic Execution rules when null coalescing is combined with arithmetic expressions because we do not support constraints on integers

8

When an IF statement uses the null conditional rule and (or?) the null coalescing operator then the else path is not marked as cannot be null, resulting in false S2259...

ChaosCrafter

Investigate why S2259 does not always trigger on C# 8 code

7

### Description C#8 introduces the concept of non-nullable reference types. By default, the reference types are considered non-nullable. See details in [Nullable reference types](https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#nullable-reference-types). I analyzed andrei-epure-sonarsource/CSharp8Demo [on SonarCloud](https://sonarcloud.io/dashboard?id=Cs8Demo). Note...

andrei-epure-sonarsource