Kirill Bulatov

Results 478 comments of Kirill Bulatov

I think there's no way around `Project::open_path` (or, maybe, workspace counterparts above, but that seems to change nothing) — good that there's a centralized place to call the pop-up in,...

`gpui::Task` is somewhat special and may act as a Rust Future (not running unless `.await`'ed) but not in this case definitely: it's the sync code that starts opening the file...

Quite a lot to change here still, so will close it for now as stale — feel free to reopen and/or discuss it further.

https://github.com/zed-industries/zed/pull/9813 might have helped with this: now, unless the deleted file was edited in the multibuffer, it should not touch it on save.

Passing by and wanted to thank you for the SVG rendering in Zed, now I can browse its icons from within! Yet, this PR seem to break this capability away,...

Sorry, did not indicate it clear enough: `assets/icons/file_icons/quote.svg` is a path inside this repository, Zed comes with a bunch of bundled SVGs: https://github.com/zed-industries/zed/tree/main/assets/icons

@MatthiasGrandl did it work for you when you tested it on Zed assets? For me, nothing is shown at all now: ![image](https://github.com/zed-industries/zed/assets/2690773/e1c81285-f5dd-4432-9571-275029c0b8f9) compared to weirdly positioned, but working still in...

Thank you for looking into that. I've started clicking through them and a few worked, but very soon (e.g. after opeing `assets/icons/at_sign.svg` and waiting ~1s), it started panicking with something...

Beautiful! I was able to click through all icons without a crash this time, thank you. I'll leave the code review to @mikayla-maki as the one with the deletion context...

Will be fixed in https://github.com/zed-industries/zed/pull/11931 and shipped with Zed 0.137, thank you.