zed icon indicating copy to clipboard operation
zed copied to clipboard

Multiple Quit Confirmation Dialogs

Open rommyarb opened this issue 1 year ago • 1 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

When I edit a file without saving it and try to force close Zed with CMD+Q multiple times, the exact amount of confirmation dialogs will also pop up after pressing the buttons on the dialog.

🔧 How to reproduce:

  1. Open a file.
  2. Edit it, but don't save the changes.
  3. Force close Zed by pressing CMD+Q multiple times.

Environment

Zed v0.129.2 aarch64

System Software Overview:

  System Version: macOS 13.5.2 (22G91)
  Kernel Version: Darwin 22.6.0
  Boot Volume: Macintosh HD
  Boot Mode: Normal
  Computer Name: *****
  User Name: *****
  Secure Virtual Memory: Enabled
  System Integrity Protection: Enabled
  Time since boot: 5 days, 7 hours, 52 minutes


Hardware Overview:

  Model Name: MacBook Pro
  Model Identifier: MacBookPro18,1
  Model Number: MK1E3ZP/A
  Chip: Apple M1 Pro
  Total Number of Cores: 10 (8 performance and 2 efficiency)
  Memory: 16 GB
  System Firmware Version: 8422.141.2
  OS Loader Version: 8422.141.2
  Serial Number (system): *****
  Hardware UUID: *****
  Provisioning UDID: *****
  Activation Lock Status: Enabled

If applicable, add mockups / screenshots to help explain present your vision of the feature

🎬 Screen capture: ZedApril052024100754

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

📄 Zed.log

rommyarb avatar Apr 05 '24 03:04 rommyarb

This seems to happen with Cmd-w as well. Given 3 files where the first I'm trying to close has changes and I hit Cmd-w 3 times, I end up getting 3 prompts to confirm I want to close the unsaved file. Once I confirm the first prompt, the file with changes closes. After confirming the following prompts the other 2 files I wanted to close remain open.

kylekthompson avatar May 07 '24 12:05 kylekthompson

Will be fixed in https://github.com/zed-industries/zed/pull/11931 and shipped with Zed 0.137, thank you.

SomeoneToIgnore avatar May 16 '24 19:05 SomeoneToIgnore