Kirill Bulatov

Results 478 comments of Kirill Bulatov

I would start with the simple approach first and, if that looks ok after implementing, give the options a stab. I'm not sure options will work that well, because they...

This is the regex we use to detect "words" that might become paths: https://github.com/zed-industries/zed/blob/50dd38bd0283d341d249d34769f59f7225a4f37c/crates/terminal/src/terminal.rs#L420 and here are the hacks we do to support `[]` in paths: https://github.com/zed-industries/zed/blob/50dd38bd0283d341d249d34769f59f7225a4f37c/crates/terminal/src/terminal.rs#L834-L848 Seems that it...

Great, thank you for helping with that and glad to see another `good first issue` label telling the truth.

Definitely, thank you for reminding.

> Are there background processes that add or remove worktrees, and can affect search results? I'm thinking of the collab mode, when the client has the file finder open, and...

I propose to delete the dependency and merge the whole thing, optionally including the conditional compilation proposal.

Why not. Project panel close-open toggling now resets its revealed item — might be related to such broad subscription and would be nice to fix 🙂

Do you have any examples from other ide/editors that support this feature?

Zed uses tree-sitter queries for everything including highlights, you can check out `${LANGUAGE_NAME}/highlights.scm` for examples, e.g. TypeScript ones: https://github.com/zed-industries/zed/blob/934af6ad451684fa2659fc0f9fb943e02c5b3572/crates/languages/src/typescript/highlights.scm Not sure what "TS query language" is so not sure I...

Ok, in that case I would rather ask @maxbrunsfeld for clarifications. From my amateur point of view, there's no strict mappings defined for any of the languages, but I might...