Alan M. Carroll

Results 26 comments of Alan M. Carroll

@zwoop has been complaining about this for years. The internals are terrible, even for ATS. I've done some work on this but hit a blocker I haven't had time to...

Ouch! ``` include/yaml-cpp/node/detail/node_iterator.h:56:19: error: 'template struct std::iterator' is deprecated [-Werror=deprecated-declarations] 56 | : public std::iterator

This can be done by overriding / supplying a deleter for `std::unique_ptr`. I think we will probably want to keep our classes for this but change the underlying implementation to...

We should do better, but as a stop gap enable the debug tag "url_rewrite". That should provide a lot more data.

I've built on CentOS 8 (I don't have EL 8) and didn't see this issue. You should not need any "yamlcpp" package as that is contained inside the ATS codebase....

I thought we were shifting to using the terms "INBOUND" and "OUTBOUND" instead of "CLIENT" and "SERVER".

It is also very standard (from the early days of C coding, which I remember personally) to omit `break` for cases that have completely identical code, as in this situation....

That said, the errors are a bit odd, particularly this one ``` - 502 https://127.0.0.1:``/ 2 0 ? ^^ + 502 https://127.0.0.1:61712/ 2 0 ? ^^^^^ ``` My understanding was...

This may be related to the problem: On master - ``` case NXDOMAIN: case 6: // YXDOMAIN case 7: // YXRRSET case 8: // NOTAUTH case 9: // NOTAUTH case...

Seems fine. A couple of notes, although not worth delaying the merge. For the names, we might consider using [Lexicon](http://docs.solidwallofcode.com/libswoc/code/Lexicon.en.html), although the utility is less because it's a one way...