trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Add TCP info from server socket

Open serrislew opened this issue 2 years ago • 7 comments

Current tcpinfo condition from header_rewrite plugin only provides tcp info from the client socket.

  • Adding a CLIENT and SERVER qualifier within this condition will provide tcp info from both client and server sockets. This could be beneficial in getting more info on the server connection behavior

serrislew avatar Apr 29 '22 00:04 serrislew

Please add to the existing documentation as well. thanks.

shukitchan avatar Apr 29 '22 18:04 shukitchan

I thought we were shifting to using the terms "INBOUND" and "OUTBOUND" instead of "CLIENT" and "SERVER".

SolidWallOfCode avatar May 02 '22 23:05 SolidWallOfCode

As per amc's question, I wonder if this should be changed to e.g.

%{TCP-INFO:INBOUND}
%{TCP-INFO:OUTBOUND}

or

%{INBOUND:TCP-INFO}
%{OUTBOUND:TCP-INFO}

? Also, this patch (or the above) would both be incompatible with current version of ATS 9.x right? As such, we can't put such a change into 9.x, unless you keep the old variation and add the new as an addition.

zwoop avatar May 06 '22 16:05 zwoop

New changes should still be compatible. Without qualifiers, it defaults to previous behavior, using the client (inbound) socket.

serrislew avatar May 06 '22 17:05 serrislew

[approve ci]

serrislew avatar May 13 '22 17:05 serrislew

[approve ci autest]

bryancall avatar Aug 29 '22 23:08 bryancall

[approve ci]

bryancall avatar Aug 29 '22 23:08 bryancall

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Nov 28 '22 02:11 github-actions[bot]