SohamBhattacharya

Results 13 comments of SohamBhattacharya

Hi @ydennisy, did you find any solution to this? I'm also facing the same issue.

This looks fine for hlt-upgrade. The changes affect only the dev paths and not the menu, and the new variable distributions are reasonable, as already pointed out by Swagata.

> Should there be a backport to 14_0? @swagata87 Yes please. > > The changes affect only the dev paths and not the menu, > > if that's the case...

> > Should there be a backport to 14_0? > > does this need the changes in #44025 as well? I'd say not necessarily -- this PR essentially adds a...

> > does this need the changes in #44025 as well? > > If #44025 wasn't backported to 14_0_X, then a verbatim backport of my PR will not work. But...

This PR looks fine from the hlt-upgrade pov.

> Shouldn't one use `year=2026` instead of `2017`? > > https://github.com/cms-sw/cmssw/blob/a288c8fdd1cbc6f2e0759f8ebbaa9763c76a7e70/HLTrigger/Configuration/python/HLT_75e33/modules/hltHpsPFTauDeepTauProducer_cfi.py#L14 > > and also [deepTau_2026v2p5_core.pb](https://github.com/cms-data/RecoTauTag-TrainingFiles/blob/master/DeepTauId/deepTau_2026v2p5_core.pb) etc files in here? > > https://github.com/cms-sw/cmssw/blob/a288c8fdd1cbc6f2e0759f8ebbaa9763c76a7e70/HLTrigger/Configuration/python/HLT_75e33/modules/hltHpsPFTauDeepTauProducer_cfi.py#L10-L12 I see this is also there in...

> To me, the next pre-release, CMSSW_13_3_0_pre4, is targeted on 2023/10/17. So if you can't fix it by, let's say, a week before (10 Oct), then please make a PR...

> > Is there anything that I should do for disabling the path? > > removing any reference from the menu (while keeping the configuration fragment) should be enough. >...

@HaarigerHarald thanks for this PR -- it makes accessing the AlgoBlock decisions a lot easier. The changes to the HLT modules look okay to me.