cms-sw
Produce r9 and trackIso(hollow cone) in EGamma development path
PR description:
We would like to explore the potential of the variables r9 and track isolation (hollow cone) in the context of phase2 photon paths. The photon paths in Run2/Run3 use these variables, but we haven't yet explored them for phase2. This PR adds these two variables in the development path, and thus makes it easier to study these variables. Once properly studied and cuts are decided, they can be added in real HLT paths as producer+filter.
PR validation:
Phase2 HLT runs fine, and the distribution of new variables look reasonable. Left plot: r9, Right plot: track iso (hollow cone)
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44423/39495
- This PR adds an extra 36KB to repository
A new Pull Request was created by @swagata87 for master.
It involves the following packages:
- HLTrigger/Configuration (hlt)
@mmusich, @Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks. @SohamBhattacharya, @silviodonato, @missirol, @Martin-Grunewald, @rovere this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70955d/38167/summary.html
COMMIT: cca7d58d2a0f484df968c8b1c2de6380c146b939
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44423/38167/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 15 lines from the logs
- Reco comparison results: 49 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297383
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297357
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: found differences in 5 / 46 workflows
This looks fine for hlt-upgrade. The changes affect only the dev paths and not the menu, and the new variable distributions are reasonable, as already pointed out by Swagata.
The changes affect only the dev paths and not the menu,
if that's the case why do we see changes in trigger results: TriggerResults ? Aren't these:
Events Accepted Gained Lost Other Trigger
10 0 - - ~10 MC_Ele5_Open_Unseeded
10 0 - - ~10 MC_Ele5_Open_L1Seeded
part of the menu?
Should there be a backport to 14_0?
@swagata87 Yes please.
The changes affect only the dev paths and not the menu,
if that's the case why do we see changes in trigger results: TriggerResults ? Aren't these:
Events Accepted Gained Lost Other Trigger 10 0 - - ~10 MC_Ele5_Open_Unseeded 10 0 - - ~10 MC_Ele5_Open_L1Seededpart of the menu?
The Open paths are the dev paths -- it's run in the menu here for testing/debugging, but not a part of the "realistic" menu -- for e.g. the one used for timing measurements. That's what I'd meant. Sorry for the confusion.
Should there be a backport to 14_0?
does this need the changes in https://github.com/cms-sw/cmssw/pull/44025 as well?
+hlt
- see https://github.com/cms-sw/cmssw/pull/44423#issuecomment-2003568882
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Should there be a backport to 14_0?
does this need the changes in #44025 as well?
I'd say not necessarily -- this PR essentially adds a couple of new producers, which can be done in 14_0_X w/o #44025. (imo there's no real necessity to backport #44025 as it's purely technical changes. But, @rovere did you already have something in mind about backporting?)
does this need the changes in #44025 as well?
If https://github.com/cms-sw/cmssw/pull/44025 wasn't backported to 14_0_X, then a verbatim backport of my PR will not work. But a backport can still be done. But I'm thinking if a backport is really needed. The new phase2 RAW samples will be produced in 14_0_X, but we can run the HLT menu on those samples from 14_1_X, correct? In that case, I don't see why a backport would be needed..
I'd say not necessarily
no, a verbatim backport will not work, see https://github.com/cms-sw/cmssw/pull/44025#issuecomment-1985218996 (names of the collections used here changed).
does this need the changes in #44025 as well?
If #44025 wasn't backported to 14_0_X, then a verbatim backport of my PR will not work. But a backport can still be done. But I'm thinking if a backport is really needed. The new phase2 RAW samples will be produced in 14_0_X, but we can run the HLT menu on those samples from 14_1_X, correct? In that case, I don't see why a backport would be needed..
In principle yes.. :) However, for 2023 samples, we used both 13_1_0 for production as well as for running the menu for AR studies. We have not tried running the menu with 14_1_X on a 14_0_X "production-like" sample -- which is to be done once we have cut the production release. If that works, then a backport would not be necessary. So I'd say a backport is not urgent and could be made if the necessity arises.
But I'm not sure about the policy on how long we can wait before making a backport.
sorry there was a typo which I fixed now. and about backport, I think I can try to do it already, to be fully sure that everything will work also from 14_0_X.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44423/39521
- This PR adds an extra 36KB to repository
Pull request #44423 was updated. @Martin-Grunewald, @mmusich, @cmsbuild can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44423/39522
- This PR adds an extra 36KB to repository
Pull request #44423 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70955d/38224/summary.html
COMMIT: 47086290b84b6c8d117fe6a9a5d272958b72489d
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44423/38224/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 28 lines from the logs
- Reco comparison results: 46 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3297369
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3297343
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: found differences in 5 / 46 workflows
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
