Sjors Provoost

Results 275 comments of Sjors Provoost

> Is this for a particular commit? Oops, in my own code :-) re-utACK e310760da891c217d2f7805978b5eca337f5cdc8

Rebase to e8926b1 looks correct, but see `find()` issue above.

Needs rebase: ``` rpc/blockchain.cpp:2259:32: error: no viable conversion from 'std::atomic' to 'const UniValue' ``` I just added `.load()`. ``` rpc/blockchain.cpp:2301:56: error: no member named 'get_int' in 'UniValue' block = active_chain[request.params[2].get_int()];...

tACK d19cf65daff4792951964e12ae3feb4be43574f8

Same issue (macOS 10.15 Catalina). Note that when copying the DMG from my Gitian machine it doesn't show the same warning. Only when I download it. Files are identical, but...

@moneyball none. I updated my comment to reflect that it matters if you get the file as a download or via SSH from a Gitian machine.

> If all goes well, the binary package will then be recognized by GateKeeper, providing that an active internet connection is available. Which implies giving Apple an overview of all...

In practice, given that the macOS code signing maintainer is also a Gitian builder, they can do both manual steps in a single session?

I just downloaded it (note: it won't check the notary stuff if you obtain it via SSH or build yourself) and didn't get a notarization warning. Just the usual "you...