Sjors Provoost

I'd also like to use signet. Your hack looks like a good start, but you also need to adjust the ports. Normally Bitcoin Core does that by default, but nix-bitcoin...

The deprecation messages are generating a lot of noise in the Travis log: https://travis-ci.com/github/Sjors/nthkey-ios/builds/234515720

I'm fine with adding another contrib script here. But we could also make a new repo under bitcoin-core. Perhaps the choice depends on whether this tool is mainly useful for...

Concept ACK on just adding these 150 lines of Python here, and lower the barrier for people to verify these things. There's still some work in progress on fixing determinism,...

> 我最近正在休假中 Well, I'm not on holiday :-) tACK b0cfbce17a84158973ebba16f9801bd57cb70fe6 I do suggest adding a comment to `PopulateAndValidateSnapshot` in `validation.h`: > To reduce space, this function takes advantage of the...

re-ACK 923ec9043af668f3a342422d32c1c28d29018ed0 That looks good. The reason I suggested (also) writing something in the header is because it's more likely to be noticed by some future dev looking through existing...

re-utACK 71d41d536bc2f47a014c898891d77d58502c9554 Only test (rebase) and documentation changes since my last review.

> I think it would be better if the new format could include a version number so that this could be properly reported. This seems useful in general. > We...

@mzumsande I don't know, but it seems such applications should use a more portable format like SQL, see #27432

I like magic bytes. For PSBT it's just "psbt" in ascii followed by 0xff: https://en.bitcoin.it/wiki/BIP_0174 So you could use "utxo" in ascii: 0x75 0x74 0x78 0x6F 0xFF But then while...