Sjors Provoost

Results 275 comments of Sjors Provoost

We also have the RPC-side code for it now.

If we're keeping some QSettings around anyway, I might as well use that. With `bitcoind` it's trivial to just specify the network as a parameter.

I switched to using QSettings. Similar to `settings.json` these are also network dependent. The GUI does this by changing its name during the bootstrap process, right after deciding which chain...

@ShaMan239 thanks for the review! I added a translator hint and keyboard shortcuts (I can't test those on macOS, new screenshot is welcome). Unfortunately afaik Bitcoin Core can't restart itself....

Maybe I misunderstand how these shortcuts work... Wouldn't "c" take you to the chain submenu and then "b" to Bitcoin inside that menu? Or all the shortcuts global?

@promag thanks, addressed comments and added the checkmark. Though on my machine I can't see the checkmark (QT 6.1.2 via homebrew). Once you use the GUI to select a chain,...

> Maybe always add the `chain` value to settings at the first run the new code, and notify users about new behavior? Done, and added a release note. I moved...

@kallewoof @ajtowns you might enjoy this PR

> Something like this can too easily lead to loss because someone forgot they switched back to mainnet. How? The addresses are different and incompatible. It seems to me that...

Also note that in Windows it's already possible to launch with a different network: https://github.com/bitcoin-core/gui/issues/78#issuecomment-682673772