Simon Woolf
Simon Woolf
Also ran into this just now (when adding a Text Element); fix in https://github.com/evancz/elm-graphics/pull/20
(I suggested using `useBinaryProtocol: false` as a workaround to avoid msgPack, customer reports that works for them)
@mattheworiordan they're not, they're just hidden from the default `toJSON()`, see See https://jsbin.ably.io/ebemoj/6/ that uses `toString()` instead. See past discussion at https://github.com/ably/ably-js/issues/44
(FWIW I wouldn't be against making internal library use use a custom method rather than toJSON, so end-users' JSON.stringify() calls aren't affected, but Paddy prefers this way)
> that's how you control what gets packed when sending on a connection (both with JSON and msgpack transports). Since we have custom handling for data (ie base64-encoding) then we...
TBH I don't feel very strongly about this; if Paddy believes there's value in the toJSON way, I'm ok with that. I'll revert https://github.com/ably/ably-js/pull/117/commits/c7081323613c2242c64c2024dccdbfbbf4dcbbe4
Nope, as of now it's still using the toJSON hack. (There was some issue with the `prepareforsending` approach, can't remember what now, that made it not mergeable as-is, then other...
Of the above, the following four still apply: - [ ] `RTP10d` - presence#leave doesn't check if client is currently ENTERED [MO] Very low priority - [ ] `RSA8c2` -...
BTW, note from a customer on what he did when he wanted the lifetime of a subscription bound to the lifetime of a controller: ``` @ablyChannel = @Ably.channels.get('test') @ablyChannel.subscribe (message)...
> on what environment? NodeJS, browser, react native? node