ably-js icon indicating copy to clipboard operation
ably-js copied to clipboard

Lower priority spec incompatibilities

Open mattheworiordan opened this issue 9 years ago • 2 comments
trafficstars

See https://github.com/ably/ably-js/issues/43#issuecomment-159757576

  • [x] TO3b/c - log: {level: n, handler: m}. [MO] I think it's OK to leave this as is, it's specific to the lib
  • [x] RTP11a/c1 - presence#get doesn't take a waitForSync param [MO] The default of waiting is fine
  • [x] RTP13 - no Presence#syncComplete function [MO] Not sure it's really a high priority given you can just wait for sync with a get call
  • [ ] RTN11c - connect [MO] Now removed from spec
  • [ ] RSN4a - channels#release [MO] Future us problem, not high priority
  • [ ] TR4j - no ProtocolMessage#messageSerial attribute [MO] Should no longer be an issue as correct the spec
  • [ ] RTP10d - presence#leave doesn't check if client is currently ENTERED [MO] Very low priority
  • [ ] RSA8c2 - authParams shouldn't take precedence over tokenParams in case of a clash [MO] This is an edge case problem, we can look at it later
  • [ ] CD2c/d/e/f - attributes maxMessageSize, maxFrameSize, maxInboundRate, connectionStateTtl of connectionDetails aren't checked [MO] Not used now anyway, so not an issue
  • [ ] RTP15f - relies on realtime to check clientId is compatible, doesn't check itself [MO] This works for now, so it's only an optimisation, defer to later
  • [ ] TE1,TD1,CD1 - TokenRequest, TokenDetails, ConnectionDetails aren't types, just plain objects [MO] I think this is fine

┆Issue is synchronized with this Jira Bug by Unito

mattheworiordan avatar Nov 25 '15 23:11 mattheworiordan

@SimonWoolf mind reviewing if any of these still apply and simply close this issue if not?

mattheworiordan avatar Nov 16 '16 12:11 mattheworiordan

Of the above, the following four still apply:

  • [ ] RTP10d - presence#leave doesn't check if client is currently ENTERED [MO] Very low priority
  • [ ] RSA8c2 - authParams shouldn't take precedence over tokenParams in case of a clash [MO] This is an edge case problem, we can look at it later
  • [ ] CD2c/d/e/f - attributes maxMessageSize, maxFrameSize, maxInboundRate, connectionStateTtl of connectionDetails aren't checked [MO] Not used now anyway, so not an issue
  • [ ] RTP15f - relies on realtime to check clientId is compatible, doesn't check itself [MO] This works for now, so it's only an optimisation, defer to later

Of those, the maxMessageSize one (in particular for bundling purposes, per https://github.com/ably/realtime/issues/603) is the only one that strikes me as important enough to pull out of this icebox into its own issue. Edit: added https://github.com/ably/ably-js/issues/353

SimonWoolf avatar Nov 16 '16 17:11 SimonWoolf