Simon Cropp comments

Results 605 comments of


                                            Simon Cropp

what the policy on var?

for the record my preference is to always use var. It is easy to consistently apply and reason about when writing code. And for the several years that i have...

WithDestructuringDepth doesn't stop destructions

can u submit a Pull Request with a failing unit test

Ability to set the tolerance at config level

happy to consider a pull request

.NET June 2025 Update - .NET 8.0.17 and .NET 9.0.6

forgive my ocd but > .NET 8.0.17 & .NET 9.06 Breaking Change should be > .NET 8.0.17 & .NET 9.0.6 Breaking Change

Authentication.WsFederation breaks with on-premise AD FS use

@Hakon > Thank you for the warning. I have submitted a fix to IdentityModel. can you link to the fix. did it make it into net8?

Authentication.WsFederation breaks with on-premise AD FS use

please re-open. this is still broken

Authentication.WsFederation breaks with on-premise AD FS use

@mkArtakMSFT @wtgodbe @JeremyLikness @danroth27 @jennyf19 any thoughts on the above?

Generating SBOM with NuGet (`Microsoft.Sbom.Targets`) on MacoSX results in intermittent hangs

my guess as to the hang is the use of a `.GetAwaiter().GetResult()` inside an msbuild task

Fix GUID scrubber not handling GUIDs between letters and/or numbers

i understand u r generating random data. but do you actually have any real scenario where a guid would appear in text without some kind of delineation?

Fix GUID scrubber not handling GUIDs between letters and/or numbers

i understand your use of autofixture. but does that format of a guid ever appear in your production data. if not then testing, and scrubbing, for that scenario is not...