Simon Cropp

Results 471 comments of Simon Cropp

@dakersnar in my case i have some global cleanups that run as part of [snapshot testing](https://github.com/VerifyTests/Verify/blob/main/docs/scrubbers.md). these replacements run on all string properties as part of taking a json snapshot...

@danmoseley is a 63line method a candidate for inlining?

just an aside, i used this code https://github.com/SimonCropp/ObjectApproval/blob/master/src/ObjectApproval/ObjectApprover_Tuple.cs to support this scenario https://github.com/SimonCropp/ObjectApproval#named-tuples

@egil So this was an experiment to see is i could get it all working in an async manner. There are still a few more items to do, but i...

note i took a few liberties to get it building on my machine. if you decide to accept this approach. i will clean them up

will you manipulating the target assembly in the context of MSBuild?

@Phyyl how r u importing `System.Reflection.MethodBase::GetCurrentMethod`?

`ImportReference(typeof(MethodBase)` wont work since that will import the `MethodBase` that resolves in the current running code. ![image](https://user-images.githubusercontent.com/122666/50613199-e6690580-0f30-11e9-999d-e08253ef4a58.png) basically u should avoid the `ImportReference(typeof...)` approach instead u need to resolve the...

> Is there a way to get the netstandard.dll location programatically? it depends on the context. With fody i have the full MSbuild context. so msbuild passes me the path...