Simon Cropp

Results 605 comments of Simon Cropp

so the problem is this code in `VerifyRuntimePlugin` ```c# private void RuntimePluginEvents_CustomizeGlobalDependencies(object sender, CustomizeGlobalDependenciesEventArgs e) { var runtimePluginTestExecutionLifecycleEvents = e.ObjectContainer.Resolve(); runtimePluginTestExecutionLifecycleEvents.BeforeScenario += (_, runtimePluginBeforeScenarioEventArgs) => { var scenarioContext = runtimePluginBeforeScenarioEventArgs.ObjectContainer.Resolve();...

added a PR that should fix this

can u submit a PullRequest with a failing test

if you use interpolation, it means the logger cant tokenize the values. so for example ``` logger.Information($"No namespace URI base provided, using unique generated default value {defaultNamespaceUriBase}"); ``` the logger...

here is an example tokenized log message in seq https://datalust.co/seq ![contextualLog](https://github.com/user-attachments/assets/228c7d8f-5608-4f60-8091-a2217246cce7) u can see that the Handler property is tokenized out. if that log message had instead used interpolation, you...

IMO an extra nuget should be shipped that contains a dotnet tool https://learn.microsoft.com/en-us/dotnet/core/tools/global-tools-how-to-create

@DaveTryon so this should be closed?

i will fix the errors shortly

@SimonCropp this should be good to go now