Simon Krajewski

Results 881 comments of Simon Krajewski

On current development: ``` C:\git\haxe-crash>haxe build.hxml src/Macros.hx:54: build.start BaseUnit src/Macros.hx:54: field.start BaseUnit.rendering src/Macros.hx:54: crashTest.start Drawable src/Macros.hx:58: crashTest.end Drawable src/Macros.hx:58: field.end BaseUnit.rendering src/Macros.hx:58: build.end BaseUnit ``` I guess that's the expected...

@yuxiaomao Could you look into the HL failure some time?

I'm avoiding the issue for now, but this isn't a good solution. Yuxiao identified the core problem which we can reproduce from this simple code: ```haxe function array(it:Iterable) {} function...

@yuxiaomao Do you think it's ok to merge this? I'm not very happy with how genhl behaves here, but I really want to make this change in general.

Seeing how we have to solution for HL, I'll close this.

We shouldn't have to convert this to `Bytes` only to do a length == 0 check.

Isn't `r.response` typed as an `ArrayBuffer` already anyway? In that case a simple `r.response.byteLength` check should do.

An initial investigation suggests that the problem here is that `MyAbstractClass` ends up having an empty constructor. This causes `Main` to not check its inherited finals, because the assumption is...

Closed by https://github.com/HaxeFoundation/haxe/commit/d38ba0ea2a86b3942ba8b99cb2a71fc0359068da

I have reverted my change because it causes other problems. Will have to look at this again.