Simon Krajewski

Results 881 comments of Simon Krajewski

Ah, I seem to struggle with reading comprehension today... This is indeed a bit silly because we don't necessarily know which type this is about.

The space is important for alignment: ``` [9.8%] [9.9%] [10.0%]

I'm seeing a stacktrace here: ``` Called from file "list.ml", line 92, characters 20-23 Called from file "src/core/texpr.ml", line 224, characters 26-41 Called from file "src/optimization/inline.ml", line 630, characters 11-84...

To be honest I'm not sure why we designed it to allow equality checks on abstracts in general. This breaks the abstraction because the only thing we can check for...

This fails because the compiler wants to find a constructor on a class that hasn't one. There's a commented out piece of code just above: ```ocaml (* TypeloadFunction.add_constructor tctx cls...

I've changed it to give a proper error when this happens, please try with that and see if we can construct a reproducible example from what it points to!

@kLabz Could you check if this makes sense git-wise?

What OCaml version are you using (`ocamlopt -v`)?

We definitely want to support OCaml 5 in general, I think it's only going to require a few changes to make Haxe 4 compatible with it. In this case, we...

The development branch works fine with OCaml 5 as far as I'm aware, so whatever change we make has to be made on the Haxe 4 branch anyway. I'd prefer...