Simon Krajewski
Simon Krajewski
Wow that's dumb... I guess if we want to use `cl_extern` for this we have to delay it until after `save_class_state`?
The problem is that we run `onGenerate` _before_ saving the class state: ``` let t = filter_timer detail_times ["callbacks"] in List.iter (fun f -> f()) (List.rev com.callbacks.before_dce); (* macros onGenerate...
Done I took the opportunity to clean up our callback structure a bit. Keeping this open so I don't forget to put this documentation somewhere.
We can make a wiki page or something.
I think we have to calculate this by doing `{ p with pmin = p.pmax - String.length cf.cf_name }` because we don't have the accurate position in our AST. I'm...
Note that the `!=` version also fails if there's no expected type: `var a = (variant1 != null) ? variant1 : 1.0;`. The problem is that the null coalescing operator...
It's fine! I kinda hate these "look at all the possibly related scenarios" when investigating the issue, but it makes for a good test case.
Should work now! I've omitted cases 4 and 5 from your diary because that's a separate issue. It might be possible to support this by doing a normal left-to-right unification,...
Well, this actually broke something on the C# target of all things: ``` ERROR src/unit/TestNullCoalescing.hx:124: characters 4-15 124 | return null; | ^^^^^^^^^^^ | Null safety: Cannot return nullable value...
I think it's because of a C#-specific hack for `null`-typing, so it's not a problem with my change here. The problem will disappear alongside the C# target.