Simen Bekkhus

Results 1227 comments of Simen Bekkhus

I see I pretty much just repeated what @Zylphrex said in https://github.com/facebook/jest/issues/12670#issuecomment-1163133802. IMO React should do that by default (or, not _that_ as it's quite hacky 😅 but something that...

I guess you can say the underlying issue is something like https://github.com/jsdom/jsdom/issues/955. We call `window.close` before `document` is set to `null`, but while timers gets cancelled it doesn't seem like...

The issue to track in Jest is https://github.com/facebook/jest/issues/2549, but for an actual solution to the issue with `URL` you need to track is https://github.com/nodejs/node/issues/28823

@Zirro if you rebase a `timeout` option has now landed (#769)

For Jest, the `failures.test` was fixed in https://github.com/facebook/jest/commit/8c5204545669e27140d867b79ee60faf60c7fc5c. The coverage failure comes from `source-map`: ``` Error: You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize({ 'lib/mappings.wasm': ... }) before...

FWIW, the remaining test failure in Jest also happens in the test suite of `v8-to-istanbul`. I'm somewhat surprised `c8` still works in the node repo itself - their test suite...

@BethGriggs the issue is `fetch` being a global, it breaks `source-map` (with more than 160M downloads a week, although the broken v7 has less since it's async only). See https://www.runpkg.com/[email protected]/lib/read-wasm.js#1...

I opened up https://github.com/nodejs/node/issues/42638 as I think the breakage of `source-map` deserves some attention.

@BethGriggs Jest `HEAD` should be fixed by https://github.com/facebook/jest/commit/c6902a061946b45791d07ef91c37c4681f43d793. I'll be releasing a new major sometime this month which includes it, but for green CITGM maybe get `head` instead of `latest`?

Above was wrong due to https://github.com/nodejs/node/issues/42792. However, https://github.com/facebook/jest/commit/78d4088ea53c4e89915ac30d55f432be5dc83832 is green on Node 18 for Jest (modulus `react-native` example, but CITGM skips the examples). I had it in my head Node...