Sergey "Shnatsel" Davidoff

Results 943 comments of Sergey "Shnatsel" Davidoff

I've dumped the frames from this image and found that the alpha channel only has two states: fully transparent and fully opaque. It makes sense for animated images to be...

It's not like the portable SIMD implementation is incomplete, it's just that the API stability is not guaranteed yet. That's the same situation in which `TryFrom` lingered for years. There's...

That's fair! I don't expect it will fully replace the existing handwritten SIMD for every platform. More like, it will provide something in between no simd at all and platform-specific...

A few more issues fixing which would require an API break: https://github.com/image-rs/image/issues/2293 https://github.com/image-rs/image/issues/2274 https://github.com/image-rs/image/issues/2296

I believe [`OwnedFd`](https://doc.rust-lang.org/stable/std/os/unix/io/struct.OwnedFd.html) can be used to avoid `unsafe` in this case, as detailed [here](https://doc.rust-lang.org/stable/std/os/unix/io/trait.FromRawFd.html#tymethod.from_raw_fd). It's a very recent addition, but it is stable.

That's unsound, yes. But It's quite strange to read a file descriptor number of all the things from an environment variable; it would be quite difficult to specify what file...

Clap 4.5 was not released at the time of publishing cargo-audit 0.19. Without an MSRV-aware resolver in Cargo we cannot really enforce MSRV in any meaningful fashion, since any dependency...

I cannot see it in the Github Pages branch so I probably imagined it. Sorry :sweat_smile:

The extra complexity we get from dealing with git does end up causing security issues, even though we only clone a single trusted repo over an encrypted channel: https://rustsec.org/advisories/RUSTSEC-2023-0064.html

I don't want to rush this because the latest `tame-index` upgraded to a newer `gix` which upgraded to a newer `reqwest` which broke things: #1151 We need to be careful...