Sergey "Shnatsel" Davidoff
Sergey "Shnatsel" Davidoff
PR for a nicer high-level API I mentioned in the description is now up: #503
We're doing semver-breaking changes now anyway, so I'm going to close this in favor of #503 which includes all of this and more.
@ripytide it doesn't really make sense to move it to `imageproc` if `image` needs to use it anyway. Neither does it make sense to put it in a private module,...
@fintelia I've updated the code based on your feedback. Does that look good? I wasn't quite sure where to put the `Orientation` so I put it in its own file...
@fintelia I've addressed all the feedback. All good points, thank you! Sorry it took so long. Somehow I was convinced I've already done it, I must have dreamt it or...
There are some `cargo deny` and `clippy` issues on CI, but they are unrelated to the changes made in this PR.
I've renamed the module to `metadata`. I did re-export the `Orientation` type on the top level still. I think that's appropriate for this type; we might revisit that when we...
I've run the fuzzer for 25 million iterations and it found no issues!
That makes sense to me. For example, Trivy requires an explicit opt-in to look for `cargo auditable` data in binaries with the `--cataloguers` option. I believe the scalibr equivalent would...
That PR's approach with `filesystem.IsInterestingExecutable` by looking at the executable bit on Unix and file extensions on Windows sounds good to me. It sounds like it would reduce the amount...