Sergey "Shnatsel" Davidoff

Results 943 comments of Sergey "Shnatsel" Davidoff

The extractor has been available in osv-scalibr for a while, and it is getting wired up to osv-scanner in https://github.com/google/osv-scanner/pull/1770

Actually, here's a non-animated image with the same issue: [file_10413997_128x128.webp.gz](https://github.com/user-attachments/files/17400759/file_10413997_128x128.webp.gz)

Yes, `set_background_color` with `[0,0,0,0]` does fix it. That is probably slightly faster as well, because we don't have to `memset()` ourselves and can simply use `vec![]` to request pre-zeroed memory...

Firefox and Chrome displays the images with transparent background as well. And the images are clearly meant to be displayed like that, too. I think we'll have to change the...

> My guess is that the image contains a background color set to opaque white, but ImageMagick is ignoring it and compositing onto a fully transparent canvas instead. To be...

I see. That makes sense. I guess WebP background color is just a mess and we'll have to join other decoders in ignoring it :sweat_smile:

I'm not sure what you mean by "reproducing the panic messages". The issue is not about something crashing with a panic message; it is about (ab)using the presence of panic...

Oh, and if you'd like to get some binaries to try this on, you can get some here: https://github.com/rustsec/rustsec/releases/tag/cargo-audit%2Fv0.21.2 This Rust tool has a lot of dependencies that can be...

Since it's pixelated I thought the loop filter might be to blame. But `dwebp -nofilter` does not produce output that's anywhere near this pixelated, so it's not a bug in...