Shivam Pokhriyal

IllegalStateException when using showLeakDisplayActivityLauncherIcon in robolectric unit tests

1

### Description Running `LeakCanary.showLeakDisplayActivityLauncherIcon(true)` from Unit tests results throws `java.lang.IllegalStateException: LeakCanary not installed, see AppWatcher.manualInstall()` [StackTrace] ``` java.lang.IllegalStateException: LeakCanary not installed, see AppWatcher.manualInstall() at leakcanary.internal.InternalLeakCanary.getApplication(InternalLeakCanary.kt:52) at leakcanary.internal.InternalLeakCanary.setEnabledBlocking(InternalLeakCanary.kt:324) at leakcanary.LeakCanary.showLeakDisplayActivityLauncherIcon(LeakCanary.kt:401) at...

Idea is from LeakCanary https://github.com/square/leakcanary/issues/1839. Shall we have a guestbook here as well to write nice things about this plugin?

Send logs in json format to sumologic

1

cross-requested : https://github.com/dimagi/commcare-core/pull/877

Add tests to show document media provider crashes

8

## Summary Adds a test to confirm this crash: https://console.firebase.google.com/u/0/project/commcare-a57e4/crashlytics/app/android:org.commcare.dalvik/issues/5ce2e2aaf8b88c2963706428?time=last-thirty-days&versions=2.52.1%20(464182)&sessionEventKey=6133BA63028B00010FB080C17D73CF8E_1582592414843474720 ``` Caused by java.lang.NullPointerException: uri at java.util.Objects.requireNonNull(Objects.java:245) at android.content.ContentResolver.query(ContentResolver.java:1171) at android.content.ContentResolver.query(ContentResolver.java:1128) at android.content.ContentResolver.query(ContentResolver.java:1084) at org.commcare.utils.UriToFilePath.getDataColumn(UriToFilePath.java:120) at org.commcare.utils.UriToFilePath.getPathFromUri(UriToFilePath.java:83) at org.commcare.utils.FileUtil.getFileLocationFromIntent(FileUtil.java:775) at...

Add ktlint to improve linting of kotlin files

6

## Summary Saw this PR https://github.com/dimagi/commcare-core/pull/1064 and thought it might be a good idea to add ktlint. https://github.com/pinterest/ktlint is an amazing kotlin linter library which provides a built-in formatter so...

- [ ] Fix `Allow GPS` popup on opening a form. - [ ] Browserstack sometimes automatically re-open wifi, after we manually [disableWifi](https://github.com/dimagi/commcare-android/blob/master/app/instrumentation-tests/src/org/commcare/utils/InstrumentationUtility.kt#L225) causing tests to fail. - [ ]...

AttributeError: 'dict' object has no attribute 'iteritems'

1

I'm trying to delete a 1-1 chat. # Delete all messages from a direct message channel slack-cleaner --token --message --direct sherry --user johndoe It's giving me this error: AttributeError: 'dict'...