Shivam Pokhriyal

Loved the way you closed the issue without waiting for a response. And then haven't updated anything for like 4 months now?

+1 Using `filtering = true`, danger should only commit lint issues in the `added/modified` lines. Instead it comments on everything in the PR(lines below the `added` ones).

Example PR https://github.com/dimagi/commcare-android/pull/2479

Sure, I'll take a look at it.

> If the PR is high risk, "High Risk" label is set > I have confidence that this PR will not introduce a regression for the reasons below > Do...

@damagatchi retest this please

> The only thing that I'm concerned here is that https://android.googlesource.com/platform/packages/providers/MediaProvider/+/5d36def/src/com/android/providers/media/MediaDocumentsProvider.java#123 the official MediaDocumentProvider class also only checks the types to be one of image, audio or video. So I'm...

> Though we should not merge this test without the fix as it's an anti-pattern in the code to have tests for failing behaviours. It formalizes an expectation that we...

> One other thought, if it's a `content://` URI, can we check if [this code](https://github.com/dimagi/commcare-android/blob/master/app/src/org/commcare/utils/UriToFilePath.java#L90) successfully handles it ? already tried that, it returns the uri itself

Seems like `bcprov-jdk15on-1.68` contains class files that require java 15 and the build fails with ``` Execution failed for task ':app:compileCommcareDebugKotlin'. > Could not resolve all artifacts for configuration ':app:commcareDebugCompileClasspath'....